Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r211821295
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1146,6 +1146,11 @@
<str>yyyy-MM-dd HH:mm[:ss[.SSS]][z</str>
<str>yyyy-MM-dd HH:mm[:ss[,SSS]][z</str>
<str>yyyy-MM-dd</str>
+ <str>EEE, dd MMM yyyy HH:mm:ss z</str>
+ <str>EEEE, dd-MMM-yy HH:mm:ss z</str>
+ <str>EEE MMM d HH:mm:ss yyyy</str>
+ <str>EEE MMM d hh:mm:ss z yyyy</str>
--- End diff --
Yeah, that's what I thought you were going to do. You've separately tested
that the ExtractionDateUtils tests also work on these patterns in the last
issue, so we want them to be the same; otherwise due to bugs (like your 'hh')
we might inadvertently screw that up. If needed, modify/tweak one of those
tests/configs.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
