Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/438#discussion_r211821003
  
    --- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
    @@ -1146,6 +1146,11 @@
           <str>yyyy-MM-dd HH:mm[:ss[.SSS]][z</str>
           <str>yyyy-MM-dd HH:mm[:ss[,SSS]][z</str>
           <str>yyyy-MM-dd</str>
    +      <str>EEE, dd MMM yyyy HH:mm:ss z</str>
    +      <str>EEEE, dd-MMM-yy HH:mm:ss z</str>
    +      <str>EEE MMM d HH:mm:ss yyyy</str>
    +      <str>EEE MMM d hh:mm:ss z yyyy</str>
    +      <str>yyyy-MM-dd hh:mm:ss</str>
    --- End diff --
    
    Close; it'd be this:  `yyyy-MM-dd[ hh:mm:ss]`  (notice the bracket starts 
immediately after the 'dd'; otherwise we'd be wrongly insisting on a trailing 
space.  
    
    And yes, always use "HH" and not "hh" unless the pattern contains an AM/PM 
designator (and these don't).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to