Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/438#discussion_r212031794
  
    --- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
    @@ -1141,11 +1141,11 @@
       <updateProcessor class="solr.ParseDoubleFieldUpdateProcessorFactory" 
name="parse-double"/>
       <updateProcessor class="solr.ParseDateFieldUpdateProcessorFactory" 
name="parse-date">
         <arr name="format">
    -      <str>yyyy-MM-dd'T'HH:mm[:ss[.SSS]][z</str>
    --- End diff --
    
    You just changed the default date patterns to not parse patterns it parsed 
before.  We need to be cautious!  For example it used to parse a comma to 
separate the milliseconds.  And the 'T' was optional.
    
    Whatever patterns exist here ought to be identical in documentation & test 
configs (which yes is annoying to keep in sync but shouldn't change often).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to