[
https://issues.apache.org/jira/browse/LUCENE-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596332#comment-16596332
]
Adrien Grand commented on LUCENE-8469:
--------------------------------------
Let's also remove StringHelper#compare on master? The patch looks like it was
generated automatically, could you change it so that it doesn't perform sums
with zero, eg. {{FutureArrays.compareUnsigned(packedValue, Integer.BYTES,
Integer.BYTES + Integer.BYTES, maxLon, 0, Integer.BYTES)}} instead of
{{FutureArrays.compareUnsigned(packedValue, Integer.BYTES, Integer.BYTES +
Integer.BYTES, maxLon, 0, 0 + Integer.BYTES)}}?
> Inline calls to the deprecated StringHelper.compare
> ---------------------------------------------------
>
> Key: LUCENE-8469
> URL: https://issues.apache.org/jira/browse/LUCENE-8469
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 7.5
>
> Attachments: LUCENE-8469.patch
>
>
> In an attempt to limit the number of warnings during compilation I though
> it'd be nice to clean up our own stuff. This is a start: StringHelper.compare
> is used throughout the code and is delegated to FutureArrays (where it
> belongs, as the arguments are byte[], not Strings).
> This can cause other patches to not apply anymore... so we could apply this
> to master only. If anybody has a strong feeling about it, please voice it.
> The patch is trivial.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
