Oh! got it - We run our tests and other release machinery etc against a single JDK, and it is currently Java 8. I will precommit with Java 8 then. Presumably at some future date JDK11 becomes the system of record? Historically how long have we waited after a new Java release before shifting over? On Mon, Nov 19, 2018 at 9:10 AM uschindler <[email protected]> wrote: > > Github user uschindler commented on the issue: > > https://github.com/apache/lucene-solr/pull/500 > > Hi, > > Currently a Lucene release should be done with Java 8. Therefore all > checks like precommit have to be done with Java 8, otherwise we can’t be sure > that it really works with Java 8. > > Lucene can for sure be built with Java 9 or later, but some > developer-central tasks cannot be executed for various reasons (that are not > necessary for building from source). The problem here is with the ECJ tool > that is used for precommit checks. It’s the Eclipse compiler and this one > needs a version that support the module system. Unfortunately there were some > problems with updating it as it broke some parts of the checks (I tried it a > while back, mabye it’s better now). Other tools that won’t work are the > Javadocs linter, because the format of Javadocs differs in Java 9+ and > maintaining 2 different HTML parsers is too hard (because the Javadocs in the > release JAR/ZIP/TGZ are Java 8 anyways). > > As a contributor/committer of Lucene you have to use Java 8 at least for > the quality checks so we can be sure that all is fine with your code! As an > end user, you can build lucene with any version later – this is also tested > with Jenkins. > > Uwe > > > --- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
