dsmiley commented on a change in pull request #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates URL: https://github.com/apache/lucene-solr/pull/647#discussion_r279177569
########## File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc ########## @@ -51,6 +51,13 @@ With the exception of in-place updates, the whole block must be updated or delet Consequently, the field need not be defined in the schema and probably shouldn't be as it would be confusing. There is no child document field type, at least not yet. +[NOTE] Review comment: Oh, I didn't know this or forgot. Ugh; I wish this weren't so. Since \_route_ is a required parameter for this feature, is the stored/docValue of \_root_ actually truly necessary? Hmm; do we at least throw an error if this is neglected when a user tries to do a partial update to a child doc? Any way, I would put this as a sub-bullet of the existing bullet of `\_root_`. Having written a book, I know it's tempting to put all that FYI info as call-out tips/notes but it's usually better to integrate the information into the text. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
