dsmiley commented on a change in pull request #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates URL: https://github.com/apache/lucene-solr/pull/647#discussion_r279346419
########## File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc ########## @@ -51,6 +51,13 @@ With the exception of in-place updates, the whole block must be updated or delet Consequently, the field need not be defined in the schema and probably shouldn't be as it would be confusing. There is no child document field type, at least not yet. +[NOTE] Review comment: Is stored/docValues on the`_root_` field still required when the atomic update provides a root doc as the root of the update? Also, I think `useDocValuesAsStored` is best set to "false", not that it's a big deal. We probably didn't test that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
