dsmiley commented on a change in pull request #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates URL: https://github.com/apache/lucene-solr/pull/647#discussion_r279347626
########## File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc ########## @@ -51,6 +51,13 @@ With the exception of in-place updates, the whole block must be updated or delet Consequently, the field need not be defined in the schema and probably shouldn't be as it would be confusing. There is no child document field type, at least not yet. +[NOTE] Review comment: > I meant for all nested atomic updates. Only if the document which is being updated is a nested document, the _route_ param should be mandatory. This is confusing to talk about. I view "a nested document" as a nested tree of documents, both the root and child and all. Any way, essentially, what I mean is that we probably shouldn't require this param if it's superfluous, and it superfluous if the root of an update is a root document. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
