dsmiley commented on a change in pull request #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates URL: https://github.com/apache/lucene-solr/pull/647#discussion_r279205550
########## File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc ########## @@ -51,6 +51,13 @@ With the exception of in-place updates, the whole block must be updated or delet Consequently, the field need not be defined in the schema and probably shouldn't be as it would be confusing. There is no child document field type, at least not yet. +[NOTE] Review comment: I think it's okay to include a small modification here to error out if `_route_` is not provided. I'm assuming it's required only for atomic updates of child documents -- that is, when the user provides a child document as the root of the update. I don't think it is required when updating a root doc to manipulate (add/update/delete) a child doc? I wonder if we can tell the difference -- when the user makes this mistake. And if `_route_` is provided unnecessarily, ideally we would verify that its value is correct. What I wonder about is what happens when `_root_` is not stored/docValues? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
