janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318416829
##########
File path:
solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java
##########
@@ -114,7 +114,7 @@ public void testBasicAuth() throws Exception {
String baseUrl = randomJetty.getBaseUrl().toString();
verifySecurityStatus(cl, baseUrl + authcPrefix, "/errorMessages", null,
20);
zkClient().setData("/security.json", STD_CONF.replaceAll("'",
"\"").getBytes(UTF_8), true);
- verifySecurityStatus(cl, baseUrl + authcPrefix, "authentication/class",
"solr.BasicAuthPlugin", 20);
+ verifySecurityStatus(cl, baseUrl + authcPrefix, "authentication/class",
"solr.BasicAuthPlugin", 20, "solr", "SolrRocks");
Review comment:
A general comment for this test class: Why not instead add
blockUnknown=false to `STD_CONF`? We do not necessarily need to test that the
default is true in this test. With the current changes, the nature of the test
has changed and does no longer test that certain actions can be done without
credentials while other need those.
As long as we have proper testing of the behavior of the new default we
should not need to change all other tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
