janhoy commented on a change in pull request #805: SOLR-13649 change the 
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318452959
 
 

 ##########
 File path: 
solr/core/src/test/org/apache/solr/security/BasicAuthStandaloneTest.java
 ##########
 @@ -96,35 +96,35 @@ public void testBasicAuth() throws Exception {
       String baseUrl = buildUrl(jetty.getLocalPort(), "/solr"); 
       httpSolrClient = getHttpSolrClient(baseUrl);
       
-      verifySecurityStatus(cl, baseUrl + authcPrefix, "/errorMessages", null, 
20);
 
 Review comment:
   > you cannot anymore, which makes sense
   
   With an explicit `blockUnknown=false` sure you can do anonymous requests if 
those are not covered by any of the permissions set up for authentication. So 
also this test class could be reverted to initial state and just explicitly set 
blockUnknown=false -- as long as blockUnknown=true is tested elsewhere.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to