janhoy commented on a change in pull request #805: SOLR-13649 change the 
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318417661
 
 

 ##########
 File path: solr/solr-ref-guide/src/basic-authentication-plugin.adoc
 ##########
 @@ -60,7 +60,7 @@ There are several things defined in this file:
 
 Save your settings to a file called `security.json` locally. If you are using 
Solr in standalone mode, you should put this file in `$SOLR_HOME`.
 
-If `blockUnknown` does not appear in the `security.json` file, it will default 
to `false`. This has the effect of not requiring authentication at all. In some 
cases, you may want this; for example, if you want to have `security.json` in 
place but aren't ready to enable authentication. However, you will want to 
ensure that this parameter is set to `true` in order for authentication to be 
truly enabled in your system.
+If `blockUnknown` does not appear in the `security.json` file, it will default 
to `true`. This has the effect of requiring authentication for HTTP access to 
Solr. In some cases, you may not want authentication after enabling the plugin; 
for example, if you want to have `security.json` in place but aren't ready to 
enable authentication. However, you will want to ensure that `blockUnknown` is 
set to `true` or omitted entirely in order for authentication to be truly 
enabled in your system.
 
 Review comment:
   >in order for authentication to be truly enabled in your system.
   
   Change to "...in order for authentication to be enforced for all requests to 
your system"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to