janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318763377
##########
File path:
solr/core/src/test/org/apache/solr/security/BasicAuthStandaloneTest.java
##########
@@ -96,35 +96,35 @@ public void testBasicAuth() throws Exception {
String baseUrl = buildUrl(jetty.getLocalPort(), "/solr");
httpSolrClient = getHttpSolrClient(baseUrl);
- verifySecurityStatus(cl, baseUrl + authcPrefix, "/errorMessages", null,
20);
Review comment:
So my point was that there is no need to change the test behavior for this
change, we can instead add the blockUnknown=false to these tests (which is
exactly what users would do to keep existing behavior) and that's it.
I opened a PR https://github.com/MarcusSorealheis/lucene-solr/pull/1 with my
proposal which removes a bunch of unnecessary and complicating changes. You
should be able to merge it into this PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
