[ https://issues.apache.org/jira/browse/SOLR-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Weiss updated SOLR-2762: ------------------------------ Attachment: SOLR-2762.patch This is my take at fixing this issue. Took David's suggestion about complexity into account and moved the checks into a separate method. A previously failing test case added and passing. David, feel free to check now, should be fine. I plan to commit in a few hours. > FSTLookup returns one less suggestion than it should when onlyMorePopular=true > ------------------------------------------------------------------------------ > > Key: SOLR-2762 > URL: https://issues.apache.org/jira/browse/SOLR-2762 > Project: Solr > Issue Type: Bug > Components: spellchecker > Affects Versions: 3.3 > Reporter: David Smiley > Assignee: Dawid Weiss > Priority: Minor > Attachments: SOLR-2762.patch, SOLR-2762_FSTLookup_off_by_one.patch, > SOLR-2762_FSTLookup_off_by_one.patch > > > I'm using the Suggester. When I switched from TSTLookup to FSTLookup, I > noticed that it returned one fewer suggestion than what I asked for. I have > spellcheck.onlyMorePopular=true; when I set it to false, I see the correct > count. Another aspect of the bug is that this off-by-one bug only seems to > occur when my suggestion has an exact match. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org