[ 
https://issues.apache.org/jira/browse/SOLR-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105958#comment-13105958
 ] 

Dawid Weiss commented on SOLR-2762:
-----------------------------------

4am, you say? You should watch this one: 
http://www.ted.com/talks/rives_on_4_a_m.html

Anyway, I didn't commit mostly because I'm in and out of office today too. 
You're right about the ordering -- it will change with the swap() that I used. 
I'm thinking it'll be easier code-wise to shift by removing and then re-adding 
the matching element. I'll prepare a patch, won't commit.

> FSTLookup returns one less suggestion than it should when onlyMorePopular=true
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-2762
>                 URL: https://issues.apache.org/jira/browse/SOLR-2762
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>    Affects Versions: 3.3
>            Reporter: David Smiley
>            Assignee: Dawid Weiss
>            Priority: Minor
>         Attachments: SOLR-2762.patch, SOLR-2762_FSTLookup_off_by_one.patch, 
> SOLR-2762_FSTLookup_off_by_one.patch
>
>
> I'm using the Suggester.  When I switched from TSTLookup to FSTLookup, I 
> noticed that it returned one fewer suggestion than what I asked for. I have 
> spellcheck.onlyMorePopular=true; when I set it to false, I see the correct 
> count. Another aspect of the bug is that this off-by-one bug only seems to 
> occur when my suggestion has an exact match.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to