[
https://issues.apache.org/jira/browse/SOLR-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106522#comment-13106522
]
Dawid Weiss commented on SOLR-2762:
-----------------------------------
bq. That TED 4am video was entertaining but weird. Normally I think of TED
video as educational / inspiring but that was a bit random.
It's "Technology Entertainment and Design", there's actually plenty of pure
entertainers there (musicians, comedians). That 4am was quite funny to me, so I
couldn't resist.
I will update to remove before insert, thanks. I didn't think of that. All your
other remarks hold, but they're super-minor improvements compared to iterating
over the fsa or sorting scores (which we will need to do to make the bucketing
proportional), so I'd sacrifice them for code clarity this time.
> FSTLookup returns one less suggestion than it should when onlyMorePopular=true
> ------------------------------------------------------------------------------
>
> Key: SOLR-2762
> URL: https://issues.apache.org/jira/browse/SOLR-2762
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 3.3
> Reporter: David Smiley
> Assignee: Dawid Weiss
> Priority: Minor
> Attachments: SOLR-2762.patch, SOLR-2762.patch,
> SOLR-2762_FSTLookup_off_by_one.patch, SOLR-2762_FSTLookup_off_by_one.patch
>
>
> I'm using the Suggester. When I switched from TSTLookup to FSTLookup, I
> noticed that it returned one fewer suggestion than what I asked for. I have
> spellcheck.onlyMorePopular=true; when I set it to false, I see the correct
> count. Another aspect of the bug is that this off-by-one bug only seems to
> occur when my suggestion has an exact match.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
