hi, If we are going to respin I would like to consider this PR https://github.com/apache/lucene/pull/13877 which is a forward port of a change we did in 9.11.1 which has arised after we reverted https://github.com/apache/lucene/pull/13857. The change is straightforward so I don't think there is any risk here.
Thanks, Ignacio On Wed, Oct 9, 2024 at 9:37 AM Dawid Weiss <dawid.we...@gmail.com> wrote: > > > If we're respinning, can I also add this to the release branch? > > https://github.com/apache/lucene/pull/13825 > > This change affects the API of DataInput, which is an important core > interface, but it does have a strong rationale for people who use these > classes directly in downstream libraries. > > I'll apply this change to branch_10x right now - without touching the release > branch. > > Dawid > > On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless <luc...@mikemccandless.com> > wrote: >> >> Hello, >> >> Alas, I fear this issue is likely a (late breaking!) blocker for 10.0.0? >> >> https://github.com/apache/lucene/issues/13867 >> >> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x written >> indices using HNSW scalar quantization at defaults. I have not tested but I >> strongly expect the current 10.0.0 RC to also have broken reading 9.11.x >> written indices (with HNSW scalar quantization) too. Thank you to Ionut >> Anghelcovici Lucene user for catching this and opening a well-written issue. >> >> I'm first (now) trying to understand why our BWC tests are not catching >> this... >> >> Separately, this at least (sigh) shows the benefits of releasing 9.last >> before 10.0! Sorry about all of this!! >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zhai7...@gmail.com> wrote: >>> >>> +1 >>> SUCCESS! [1:08:46.194765] >>> >>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <ben.w.tr...@gmail.com> wrote: >>>> >>>> +1 SUCCESS! [0:48:25.853452] >>>> >>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <stefan.vod...@gmail.com> >>>> wrote: >>>> > >>>> > +1 SUCCESS! [0:40:01.995275] >>>> > >>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <java...@apache.org> wrote: >>>> >> >>>> >> Please vote for release candidate 3 for Lucene 10.0.0 >>>> >> >>>> >> I published a draft of the release notes at >>>> >> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 >>>> >> . Feedback is welcome. Feel free to edit directly. >>>> >> >>>> >> The artifacts can be downloaded from: >>>> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca >>>> >> >>>> >> You can run the smoke tester directly with this command: >>>> >> >>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \ >>>> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca >>>> >> >>>> >> The vote will be open for at least 72 hours i.e. until 2024-10-09 17:00 >>>> >> UTC. >>>> >> >>>> >> [ ] +1 approve >>>> >> [ ] +0 no opinion >>>> >> [ ] -1 disapprove (and reason why) >>>> >> >>>> >> Here is my +1 >>>> >> >>>> >> SUCCESS! [0:38:43.010208] >>>> >> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>>> For additional commands, e-mail: dev-h...@lucene.apache.org >>>> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
