OK the 9.12.x PR is merged ... I'll next cherry-pick to 10.0.x and 10.x. Mike McCandless
http://blog.mikemccandless.com On Wed, Oct 9, 2024 at 12:36 PM Michael McCandless < luc...@mikemccandless.com> wrote: > Thanks Luca, I'm still actively working on the back compat break / > blocker. I'm hoping to finish the PR and merge it to 9.12.x later today, > and then forward port to 10.0.x and 10.x. > > Mike McCandless > > http://blog.mikemccandless.com > > > On Wed, Oct 9, 2024 at 12:19 PM Luca Cavanna <java...@apache.org> wrote: > >> All of the backports that we wanted to get in have been cherry picked, as >> far as I know. >> >> I've seen quite a bit of activity on different PRs around the release >> blocker, I know there's a couple of in-flight PRs, please give me a shout >> when we are ready to go and I'll respin. >> >> Thanks >> Luca >> >> On Wed, Oct 9, 2024 at 11:29 AM Luca Cavanna <java...@apache.org> wrote: >> >>> Thanks for raising this Mike, I am good with respinning. >>> >>> Chris is looking into the fix for the release blocker at >>> https://github.com/apache/lucene/pull/13874 and forward porting it to >>> branch_10_0. >>> >>> Dawid, I am also good with backporting your fix, I commented in the PR >>> about adding a missing CHANGES entry. Does this also need to be mentioned >>> in the migrate guide? >>> >>> Another change we would like to make in branch_10_0 is >>> https://github.com/apache/lucene/pull/13877 . This was made only in 9x >>> so far, and is needed in 10 as well now that >>> https://github.com/apache/lucene/pull/13221 has been reverted. >>> >>> I will go ahead and merge https://github.com/apache/lucene/pull/13858 >>> as well. >>> >>> >>> Cheers >>> Luca >>> >>> On Wed, Oct 9, 2024 at 9:37 AM Dawid Weiss <dawid.we...@gmail.com> >>> wrote: >>> >>>> >>>> If we're respinning, can I also add this to the release branch? >>>> >>>> https://github.com/apache/lucene/pull/13825 >>>> >>>> This change affects the API of DataInput, which is an important core >>>> interface, but it does have a strong rationale for people who use these >>>> classes directly in downstream libraries. >>>> >>>> I'll apply this change to branch_10x right now - without touching the >>>> release branch. >>>> >>>> Dawid >>>> >>>> On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless < >>>> luc...@mikemccandless.com> wrote: >>>> >>>>> Hello, >>>>> >>>>> Alas, I fear this issue is likely a (late breaking!) blocker for >>>>> 10.0.0? >>>>> >>>>> https://github.com/apache/lucene/issues/13867 >>>>> >>>>> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x >>>>> written indices using HNSW scalar quantization at defaults. I have not >>>>> tested but I strongly expect the current 10.0.0 RC to also have broken >>>>> reading 9.11.x written indices (with HNSW scalar quantization) too. Thank >>>>> you to Ionut Anghelcovici Lucene user for catching this and opening a >>>>> well-written issue. >>>>> >>>>> I'm first (now) trying to understand why our BWC tests are not >>>>> catching this... >>>>> >>>>> Separately, this at least (sigh) shows the benefits of >>>>> releasing 9.last before 10.0! Sorry about all of this!! >>>>> >>>>> Mike McCandless >>>>> >>>>> http://blog.mikemccandless.com >>>>> >>>>> >>>>> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zhai7...@gmail.com> >>>>> wrote: >>>>> >>>>>> +1 >>>>>> SUCCESS! [1:08:46.194765] >>>>>> >>>>>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <ben.w.tr...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> +1 SUCCESS! [0:48:25.853452] >>>>>>> >>>>>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita < >>>>>>> stefan.vod...@gmail.com> wrote: >>>>>>> > >>>>>>> > +1 SUCCESS! [0:40:01.995275] >>>>>>> > >>>>>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <java...@apache.org> >>>>>>> wrote: >>>>>>> >> >>>>>>> >> Please vote for release candidate 3 for Lucene 10.0.0 >>>>>>> >> >>>>>>> >> I published a draft of the release notes at >>>>>>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 >>>>>>> . Feedback is welcome. Feel free to edit directly. >>>>>>> >> >>>>>>> >> The artifacts can be downloaded from: >>>>>>> >> >>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca >>>>>>> >> >>>>>>> >> You can run the smoke tester directly with this command: >>>>>>> >> >>>>>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \ >>>>>>> >> >>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca >>>>>>> >> >>>>>>> >> The vote will be open for at least 72 hours i.e. until 2024-10-09 >>>>>>> 17:00 UTC. >>>>>>> >> >>>>>>> >> [ ] +1 approve >>>>>>> >> [ ] +0 no opinion >>>>>>> >> [ ] -1 disapprove (and reason why) >>>>>>> >> >>>>>>> >> Here is my +1 >>>>>>> >> >>>>>>> >> SUCCESS! [0:38:43.010208] >>>>>>> >> >>>>>>> >>>>>>> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>>>>>> For additional commands, e-mail: dev-h...@lucene.apache.org >>>>>>> >>>>>>>
