On Sun, Jan 8, 2012 at 5:18 PM, Robert Muir <[email protected]> wrote: > On Sun, Jan 8, 2012 at 9:30 AM, Simon Willnauer > <[email protected]> wrote: >> hey folks, >> >> now that we have everything under codec control and norms are cut over >> to docvalues I wonder what keeps us from moving towards a 4.0 beta >> release. > > here are my thoughts: > > But just taking that issue (not to try to pick on it): this is a > little incomplete for a few reasons: > 1. Shouldn't we remove the limitation that norms are single byte? I > started looking at this and it reveals some hair I think and creates > some interesting questions.
+1 > 2. Shouldn't docvalues have a a simpletext implementation? I know the > api is a little simpler now, but previously there was no way I could > have written a simpletext implementation if my life depended on it. +1 > 3. There were some API todos listed on the issue: I think those TODOs > are important (like all the extra add methods and lucene-40 private > bulk shit in the abstract api). These are new APIs so I think we > should try to tackle these. FYI - those extra add methods are unrelated to the bulk stuff - I pulled them up to implement the default merging. > > Otherwise, as before we still have to figure out how modules are being > packaged, and we still have to review other apis and in general do a > lot of testing and refactoring and bugfixing. Agreed. > > From the tests/bugfixing perspective, on trunk its not hard to dig > into stuff here and there and find lots of really horrible bugs that > exist in trunk-only. This is a sign that our tests are not good enough > and that the code is not stable enough. I don't understand this entirely, can you elaborate? if there are horrible bugs there should be issues marked as blocker. > > For apis perspective: all the apis really need some serious reviewing: > if anything is abstract it needs multiple implementations (even ones > in src/test). Lots of the javadoc is outdated, even in trunk itself > and needs to be cleaned up. The MIGRATE.txt and CHANGES.txt needs to > be reviewed and up to date. We have to deal with things like > fileformats.html. I'm just going to quit typing now because this email > will just keep getting longer and longer. I did ask to push the release tomorrow. I personally feel some frustration that lucene 4 is still not released and I think we are really close. From my perspective we should build some kind of roadmap to get lucene 4 or a beta out lets say within the next 2 month and concentrate on getting the remaining issues resolved. We should collect issues and problems and mark them as blockers so we can pick them up and get it out of the door. Right now all the issues you listed are somewhat known but there is no way to access them, I suggest we open JIRA ticket and decide issue per issue if they are blockers or not. A SimpleText impl for docvalues are certainly nice to have but not a blocker from my perspective. I already worked on it and it will make it into 4.0 but we need to mark those issues that are real blockers. thoughts? simon > > -- > lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
