[ 
https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413711#comment-13413711
 ] 

David Smiley commented on LUCENE-4173:
--------------------------------------

Instead of this boolean flag on the strategy to ignore the shape, I propose the 
Strategy more clearly declares which shapes it can index.  Perhaps:
{code}
boolean canIndex(Shape);
{code}
or
{code}
Class<Shape>[] getIndexableShapes()
{code}
                
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
>                 Key: LUCENE-4173
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4173
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/spatial
>            Reporter: Chris Male
>         Attachments: LUCENE-4173.patch
>
>
> Silently not indexing anything for a Shape is not okay.  Users should get an 
> Exception and then they can decide how to proceed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to