[
https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414576#comment-13414576
]
Chris Male commented on LUCENE-4173:
------------------------------------
{quote}
Having said all this, and even suggested these methods for consideration, I
don't think these informational meta methods are particularly useful because
about the only real use-case I can think of is the strategy demo, which is
so-so of a use-case, IMO, and consumer-level alternatives could be added. I
think Javadoc on the Strategy is fine and should be required anyway – I
shouldn't have to write code or find the source to determine what operations
are supported. To that end, I will add some documentation to these Strategies
soon.
{quote}
I agree. Documentation is really the only way we can convey all subtle
differences in the Strategys. In addition the the class level javadoc, perhaps
we can expand the package.html with some tables of Strategys vs. supported
shapes and vs. supported operations. As long as we keep that up to date, it'll
be a nice reference.
This still poses the question of what to do in a Strategy when given a Shape
that is unsupported. Are you okay with the approach in the patch of just
throwing the Exception?
{quote}
I don't like it either. And I really don't like it "automatically degrading"
(e.g. convert circle to its bbox). – just hand in the the bbox then, or make
the degrading configurable at the least so the user is very clear what's
happening.
{quote}
Yeah that is very reasonable. I think we need to encourage in documentation
that Strategys are much like analysis components, you need to consider which
you choose carefully, you need to understand what they do and you will need to
experiment.
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
> Key: LUCENE-4173
> URL: https://issues.apache.org/jira/browse/LUCENE-4173
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Attachments: LUCENE-4173.patch
>
>
> Silently not indexing anything for a Shape is not okay. Users should get an
> Exception and then they can decide how to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
