[
https://issues.apache.org/jira/browse/SOLR-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419680#comment-13419680
]
Robert Muir commented on SOLR-3623:
-----------------------------------
Sorry... lemme try to explain in more detail:
{quote}
can you be specific as to what you mean by "the morfologik jars" ? because
evidently i don't have a clue what that means and i missunderstood what you
were including in that list originally (i thought you ment all of the
anlysis-extra libs that weren't ICU).
{quote}
{noformat}
WEB-INF/lib/lucene-analyzers-morfologik-4.0-SNAPSHOT.jar <-- this is the lucene
integration code (analyzer, tokenfilter)
WEB-INF/lib/morfologik-fsa-1.5.3.jar <-- these 3 jars are dependencies of the
above
WEB-INF/lib/morfologik-polish-1.5.3.jar
WEB-INF/lib/morfologik-stemming-1.5.3.jar
{noformat}
But this does not good for solr users: because the factory
(MorfologikFilterFactory.java) is in apache-solr-analysis-extras.jar.
Furthermore, I think having this situation (where these files are in the war,
but the factory as a plugin) causes classloader hell.
So with the factory in this contrib module, the jar files should really be
going in contrib/analysis-extras/lucene-libs as part of the packaging process
just like the other dependencies this contrib module has, otherwise we should
move the factory to core (see below)
{quote}
are you saying it is good or bad that lucene-analyzers-smartcn is not currently
in solr core? (ie: in your opinion, should SmartChinese*Factory move into
solr/core ?)
{quote}
In my opinion, it would be nice because we could have a text_zh configured in
the example that indexes chinese as words. Currently to do this, you have to
deal with this huge hassle that is this crazy analysis-extras contrib which is
a big barrier for indexing Chinese text.
But thats just my opinion, i hate the contrib in general because I think its a
pain to use. The reason it exists was because I initially wanted to integrate
smartchinese with solr but there were concerns about it increasing the size of
the .war file since the smart chinese jar is 3MB. So I created this contrib and
added factories for any analyzers that didnt have factories just as a way of at
least providing some help to make them usable. Just FYI: the solr.war is near
20MB now.
Still, as it is, at least its some way to provide factories for these analyzers
versus having none before.
{quote}
again: what exactly do you mean by "wrong place" ?
am i correct in understanding that you feel they should be in the war file, but
that it is a mistake they are not included in solr.base.classpath at compile
time?
{quote}
Under the current setup, the factory is in contrib/analysis-extras. the
contrib/analysis-extras build logic puts these dependencies into
contrib/analysis-extras' classpath so the tests will pass.
If we want to move the factories to core, then we have to adjust the solr core
classpath to then include the jar files instead.
{quote}
a quick glance at that reveals other things in that classpath that shouldnt be
in there like analyzers-uima.jar (which, should instead be configured in the
uima contrib's classpath only)
{quote}
Here is contrib/uima/build.xml:
{noformat}
<path id="classpath">
<pathelement path="${analyzers-uima.jar}"/>
<path refid="solr.base.classpath"/>
</path>
{noformat}
So its useless to have analyzers-uima in the solr core classpath, because in
the current packaging solr core code should not be depending on this jar. And
contrib/uima already adds this itself.
> analysis-extras lucene libraries are redundenly packaged (in war and in
> lucene-libs)
> ------------------------------------------------------------------------------------
>
> Key: SOLR-3623
> URL: https://issues.apache.org/jira/browse/SOLR-3623
> Project: Solr
> Issue Type: Bug
> Components: Build
> Reporter: Lance Norskog
> Assignee: Hoss Man
> Priority: Minor
> Fix For: 4.0, 5.0
>
>
> Various dependencies for contrib/analysis-extras are packaged
> contrib/analysis-extras/lucene-libs (along with instructions in
> contrib/analysis-extras/README.txt that users need to include them
> explicitly) even though these jars are already hardcoded into the solr war
> file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
