[ 
https://issues.apache.org/jira/browse/SOLR-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419717#comment-13419717
 ] 

Robert Muir commented on SOLR-3623:
-----------------------------------

patch looks good, except I agree with you about the 3rd party jars.

Lets be consistent on that: 

I think it should be in the ivy.xml, with LICENSE/NOTICE in lib/ 
It would then get pulled into the classpath because its in lib/

                
> analysis-extras lucene libraries are redundenly packaged (in war and in 
> lucene-libs)
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-3623
>                 URL: https://issues.apache.org/jira/browse/SOLR-3623
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>            Reporter: Lance Norskog
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>         Attachments: SOLR-3623.patch
>
>
> Various dependencies for contrib/analysis-extras are packaged 
> contrib/analysis-extras/lucene-libs (along with instructions in 
> contrib/analysis-extras/README.txt that users need to include them 
> explicitly) even though these jars are already hardcoded into the solr war 
> file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to