[
https://issues.apache.org/jira/browse/LUCENE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594956#comment-13594956
]
Shai Erera commented on LUCENE-3918:
------------------------------------
Thanks Rob - I didn't know we can check these things :). Certainly better than
suppressing the entire Codec.
Adrien, thanks for the update as well. So if someone loads NumericDV (default),
indeed there's no need to copy the values again into an array. If someone uses
DiskDVFormat though, list.get(i) will access the disk on every call ... but I
guess that's fine since if someone wanted to save RAM, he should be ready to
pay the price, and we should respect him.
bq. I still don't get why someone would use stored fields rather than doc
values (either binary, sorted or numeric) to sort his index. I think it's
important to make users understand that stored fields are only useful to
display results?
Someone might have an existing index without DV. Also, who said that a stored
field used for display cannot be used to sort the index?
But, since it's quite trivial to implement, I'll remove both Payload and
StoredFields. I'll also make Reverse and Numeric sorters inner classes (though
public) of Sorter.
I added a check in SortingAtomicReader ctor that old2new.length ==
reader.maxDoc(), to ensure that sorters provide a mapping for every document in
the index.
I'll get rid of IndexSorter, but keep a test around + add to SortingAR javadocs
code example how to use it for addIndexes.
Will upload a new patch later.
> Port index sorter to trunk APIs
> -------------------------------
>
> Key: LUCENE-3918
> URL: https://issues.apache.org/jira/browse/LUCENE-3918
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/other
> Affects Versions: 4.0-ALPHA
> Reporter: Robert Muir
> Fix For: 4.2, 5.0
>
> Attachments: LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch,
> LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch,
> LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch,
> LUCENE-3918.patch, LUCENE-3918.patch
>
>
> LUCENE-2482 added an IndexSorter to 3.x, but we need to port this
> functionality to 4.0 apis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
