[
https://issues.apache.org/jira/browse/LUCENE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594650#comment-13594650
]
Adrien Grand commented on LUCENE-3918:
--------------------------------------
Thanks for your work Shai. Indeed it looks really good now! Here a a few
suggestions/questions:
- Are there actual use-cases for sorting by stored fields or payloads? If not
I think we should remove StoredFieldsSorter and PayloadSorter?
- Remove IndexSorter.java and make SortDoc package-private?
{code}
+ // we cannot reuse the given DocsAndPositionsEnum because we return our
+ // own wrapper, and not all Codecs like it.
{code}
Maybe we could check if the docs enum to reuse is an instance of
SortingDocsEnum and reuse its wrapped DocEnum?
> Port index sorter to trunk APIs
> -------------------------------
>
> Key: LUCENE-3918
> URL: https://issues.apache.org/jira/browse/LUCENE-3918
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/other
> Affects Versions: 4.0-ALPHA
> Reporter: Robert Muir
> Fix For: 4.2, 5.0
>
> Attachments: LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch,
> LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch,
> LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch
>
>
> LUCENE-2482 added an IndexSorter to 3.x, but we need to port this
> functionality to 4.0 apis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
