[
https://issues.apache.org/jira/browse/LUCENE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594799#comment-13594799
]
Shai Erera commented on LUCENE-3918:
------------------------------------
Robert, now that I think about it again, I'm not sure if SortingAtomicReader
should do anything to prevent usage over such Codecs. The list of codecs that
do not support indexing offsets are there because the test indexes offsets. But
SortingAtomicReader itself doesn't care about whether the Codec supported or
not offsets -- it will get -1 for offsets (that's what happened before I set
IndexOptions correctly!). I think that's fine?
As for the new DV features, again, the reader itself is immune to this? I.e.
you would get same exception if you opened a 4.0 index and called
getSortedSetDV(i)?
I think it's fine that the reader doesn't yell at you, and I wish we could test
those codecs somehow, ignoring the unsupported methods, but I also think that
these tests are not the ones that just *must* test all Codecs. It's a generic
filter reader and it will yell at you just like any other filter reader will,
if you call unsupported API?
> Port index sorter to trunk APIs
> -------------------------------
>
> Key: LUCENE-3918
> URL: https://issues.apache.org/jira/browse/LUCENE-3918
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/other
> Affects Versions: 4.0-ALPHA
> Reporter: Robert Muir
> Fix For: 4.2, 5.0
>
> Attachments: LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch,
> LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch,
> LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch
>
>
> LUCENE-2482 added an IndexSorter to 3.x, but we need to port this
> functionality to 4.0 apis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
