[
https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606439#comment-13606439
]
Uwe Schindler commented on LUCENE-4848:
---------------------------------------
bq. Thanks for the demonstration Uwe! It was very helpful as I misunderstood
our earlier conversation and was attempting to change the internals of
FSDirectory to use Path (instead of File) while keeping the public interface
the same (actually, I was done, but waiting for the tests to run before
attaching the patch, so your timing was perfect )
We can move to Path later, but before doing that we should get this in as a
first step. This issue is unrelated.
I just skimmed your patch, this looks quite good. I have to look closer into
it, will report back later. I have seen that you almost completely reused my
patch - thanks! But you used try-with-resources to open,mmap,close the channel
- nice!
To run all Lucene+SOLR tests with a specific directory implementation use e.g.:
"ant test -Dtests.directory=MMapDirectory", otheriwse Lucene uses in most cases
RAMDirectory and only rarely other ones. By that you should also be able to
test your new directory (it might be needed that you add a hook for
instantiating it inside LuceneTestCase where -Dtests.directory is parsed).
> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>
> Key: LUCENE-4848
> URL: https://issues.apache.org/jira/browse/LUCENE-4848
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Michael Poindexter
> Assignee: Uwe Schindler
> Priority: Minor
> Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch,
> LUCENE-4848.patch
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on
> JDK7). These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5
> for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue. I'll be happy to make any
> changes requested. I've included some minimal smoke tests, but any help in
> how to use the normal Lucene tests to perform more thorough testing would be
> appreciated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
