[
https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606920#comment-13606920
]
Michael Poindexter commented on LUCENE-4848:
--------------------------------------------
I'll run the tests tonight with -Dtests.directory for the new directory, I
didn't know how to do it before. I think the threads thing is actually the
JRE...if you pass null for the executor it means to use the default system
thread pool the JRE creates for IO notifications. I'm guessing it is lazily
created and the test framework detects and flags this. I'll simply create and
use an executor explicitly for the test cases so that there is thread pool that
can be cleaned up.
I know the channel based FSIndexOutput is unused. I can remove it if you'd
like, but I wanted to put it in based on our previous conversation simply in
case it made sense at some point to use an IndexOuput that did not lock files
for delete.
Regarding the 2 new abstract methods in the base class: I'm fine with making
the length be passed in the constructor, which leaves isFDValid(). This was
why I had initially made the length method be protected instead of packaged
private: so that subclasses could be created outside of the o.a.l.store
package. I'd like to just change isFDValid() to be protected. If I do that it
will be visible to subclasses and the package, but not publicly available,
sound OK?
> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>
> Key: LUCENE-4848
> URL: https://issues.apache.org/jira/browse/LUCENE-4848
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Michael Poindexter
> Assignee: Uwe Schindler
> Priority: Minor
> Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch,
> LUCENE-4848.patch, LUCENE-4848.patch
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on
> JDK7). These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5
> for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue. I'll be happy to make any
> changes requested. I've included some minimal smoke tests, but any help in
> how to use the normal Lucene tests to perform more thorough testing would be
> appreciated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
