[
https://issues.apache.org/jira/browse/LUCENE-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618452#comment-13618452
]
Shai Erera commented on LUCENE-4858:
------------------------------------
I don't disagree, I just think that completely orthogonal to this issue,
addIndexes should respect IW's MP. I've been working with an app that relied on
having segments no bigger than X GB (controlled by MP), and having addIndexes
completely ignore these settings is a bug, at least to me. Who said that
addIndexes must end up w/ a single segment? Anyway, this is something we should
discuss on a separate issue, since it's unrelated to sorting. I'm going to
reproduce this separately, and then open a dedicated issue. This one can wait
or proceed unrelated.
bq. The current patch goes to great extremes to add more and more and more
complexity at the index-level but misses the forrest for the trees.
I don't think so? It only attempts to protect the user from silently tripping
on his bugs. To the user, nothing really changes (except that his Sorter impls
will need to define a sortKey or whatever .. big deal). The rest is completely
opaque. I'm sure you won't object to protecting users from themselves, at least
not when all we need is to make this tiny little change to OneMerge.
> Early termination with SortingMergePolicy
> -----------------------------------------
>
> Key: LUCENE-4858
> URL: https://issues.apache.org/jira/browse/LUCENE-4858
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.3
>
> Attachments: LUCENE-4858.patch, LUCENE-4858.patch
>
>
> Spin-off of LUCENE-4752, see
> https://issues.apache.org/jira/browse/LUCENE-4752?focusedCommentId=13606565&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13606565
> and
> https://issues.apache.org/jira/browse/LUCENE-4752?focusedCommentId=13607282&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13607282
> When an index is sorted per-segment, queries that sort according to the index
> sort order could be early terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
