[ 
https://issues.apache.org/jira/browse/LUCENE-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622758#comment-13622758
 ] 

Shai Erera commented on LUCENE-4858:
------------------------------------

Adrien and I chatted about it and we think that what's best to do as part of 
this issue is:

* Make a concrete EarlyTerminatingSortedCollector (instead of the ones in the 
patch), which takes a Sorter and numDocs. For every segment, it checks whether 
the reader is sorted and collects up to numDocs from each sorted segment, or 
all docs from unsorted segments.
** That's basically a combination of what EarlyTerminationCollector and 
SortingMPCollector do in the current patch.

* Add isSorted(AtomicReader, Sorter) to SortingMP, as a utility method for 
other early terminating collectors (Adrien has an idea about a few, but not as 
part of this issue).

* Clarify documentation of this collector (e.g. what early termination really 
means).

I'll work on patch in the next few days, maybe during the weekend.
                
> Early termination with SortingMergePolicy
> -----------------------------------------
>
>                 Key: LUCENE-4858
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4858
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 4.3
>
>         Attachments: LUCENE-4858.patch, LUCENE-4858.patch, LUCENE-4858.patch
>
>
> Spin-off of LUCENE-4752, see 
> https://issues.apache.org/jira/browse/LUCENE-4752?focusedCommentId=13606565&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13606565
>  and 
> https://issues.apache.org/jira/browse/LUCENE-4752?focusedCommentId=13607282&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13607282
> When an index is sorted per-segment, queries that sort according to the index 
> sort order could be early terminated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to