[ https://issues.apache.org/jira/browse/LUCENE-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622662#comment-13622662 ]
Shai Erera commented on LUCENE-4858: ------------------------------------ bq. Now that SORTER_ID_PROP is added to the diagnostics, maybe that SORTED_DIAGNOSTICS_PROP is redundant? Good point. bq. Nothing prevent you from wrapping eg. a TotalHitCountCollector inside it Well, I think that's the point where we're trying to protect the user too much. I suggest that we commit what we have, maybe clarify the javadocs to explain better what early termination means, and fix/make it more robust when users actually trip on something. bq. I'll work on improving documentation as well. Thanks. Would you mind to get rid of SORTED prop in that patch too? > Early termination with SortingMergePolicy > ----------------------------------------- > > Key: LUCENE-4858 > URL: https://issues.apache.org/jira/browse/LUCENE-4858 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Fix For: 4.3 > > Attachments: LUCENE-4858.patch, LUCENE-4858.patch, LUCENE-4858.patch > > > Spin-off of LUCENE-4752, see > https://issues.apache.org/jira/browse/LUCENE-4752?focusedCommentId=13606565&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13606565 > and > https://issues.apache.org/jira/browse/LUCENE-4752?focusedCommentId=13607282&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13607282 > When an index is sorted per-segment, queries that sort according to the index > sort order could be early terminated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org