[ 
https://issues.apache.org/jira/browse/LUCENE-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626429#comment-13626429
 ] 

Adrien Grand commented on LUCENE-4858:
--------------------------------------

Thanks for updating the patch, Shai.

bq. Adrien, do we have anything else to do here, or are we ready to go? If so, 
I'll add a CHANGES entry and commit later.

The patch looks good to me. Maybe NumericDocValuesSorter.getID() could just 
return 'fieldName'? I think it's not necessary to describe the doc values type 
since they are exclusive and doc values are the natural way to sort documents 
by field values in Lucene? Otherwise +1.
                
> Early termination with SortingMergePolicy
> -----------------------------------------
>
>                 Key: LUCENE-4858
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4858
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 4.3
>
>         Attachments: LUCENE-4858.patch, LUCENE-4858.patch, LUCENE-4858.patch, 
> LUCENE-4858.patch, LUCENE-4858.patch, LUCENE-4858.patch
>
>
> Spin-off of LUCENE-4752, see 
> https://issues.apache.org/jira/browse/LUCENE-4752?focusedCommentId=13606565&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13606565
>  and 
> https://issues.apache.org/jira/browse/LUCENE-4752?focusedCommentId=13607282&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13607282
> When an index is sorted per-segment, queries that sort according to the index 
> sort order could be early terminated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to