paulirwin commented on code in PR #897:
URL: https://github.com/apache/lucenenet/pull/897#discussion_r1462023373
##########
src/Lucene.Net.Tests/Util/TestMathUtil.cs:
##########
@@ -58,10 +57,11 @@ internal static long RandomLong()
}
// slow version used for testing
- private static bool TryGetGcd(long a, long b, out long result)
+ // LUCENENET: semantics changed to a Try pattern as BigInteger could
overflow long
+ private static bool TryGetGcd(long l1, long l2, out long result)
{
result = 0;
- var c = System.Numerics.BigInteger.GreatestCommonDivisor(a, b);
+ var c = System.Numerics.BigInteger.GreatestCommonDivisor(l1, l2);
Review Comment:
I assumed sticking to line-for-line from Java as much as possible was more
valuable. At least in my dev font it looks different enough from the numbers,
also numeric literals are usually highlighted a different color, but if you
feel strongly about this I can revert it with a LUCENENET comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
