paulirwin commented on code in PR #897:
URL: https://github.com/apache/lucenenet/pull/897#discussion_r1462040846
##########
src/Lucene.Net.Tests/Util/TestNamedSPILoader.cs:
##########
@@ -56,4 +56,4 @@ public virtual void TestAvailableServices()
Assert.IsTrue(codecs.Contains("Lucene46"));
}
}
-}
\ No newline at end of file
+}
Review Comment:
My apologies for this; I was adding a comment to the end of each file as I
reviewed it to track my progress so my IDE added the newlines. It is considered
best practice to have newlines at the end of files, and I have my IDE (Rider)
configured to do that on save. Git (and GitHub) complain about missing newlines
at ends of files as an example. As a possible solution, many open-source
projects have linters that require you to do so (SerenityOS is one that comes
to mind). That said, I don't think it provides enough value to mass convert the
entire project anytime soon or add a PR validation just for that... others
might feel this is valuable though.
I am not aware of a git config option that forces this, so I'd suggest we
just let it evolve naturally for a bit, and I'll try to avoid newline-only
changes going forward. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
