paulirwin commented on code in PR #897:
URL: https://github.com/apache/lucenenet/pull/897#discussion_r1462027715
##########
src/Lucene.Net.Tests/Util/TestBytesRefArray.cs:
##########
@@ -114,11 +114,10 @@ public virtual void TestAppendIterator()
}
for (int i = 0; i < 2; i++)
{
- IBytesRefEnumerator iterator = list.GetEnumerator();
+ IBytesRefIterator iterator = list.GetIterator();
Review Comment:
Note the name of this method; this is the Iterator version with an Obsolete
attribute on it. The code was accidentally using enumerator like the one above
it when the test was intended to test the old iterator functionality, making
the test essentially a duplicate of the one above it. We could remove the
obsolete tests entirely if you think we're ready for that, but this was fixing
what was clearly a mistake as the test above it was for enumerator while this
one was for iterator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
