NightOwl888 commented on code in PR #897:
URL: https://github.com/apache/lucenenet/pull/897#discussion_r1462157063
##########
src/Lucene.Net.Tests/Util/TestMathUtil.cs:
##########
@@ -58,10 +57,11 @@ internal static long RandomLong()
}
// slow version used for testing
- private static bool TryGetGcd(long a, long b, out long result)
+ // LUCENENET: semantics changed to a Try pattern as BigInteger could
overflow long
+ private static bool TryGetGcd(long l1, long l2, out long result)
{
result = 0;
- var c = System.Numerics.BigInteger.GreatestCommonDivisor(a, b);
+ var c = System.Numerics.BigInteger.GreatestCommonDivisor(l1, l2);
Review Comment:
Yea, let's revert this. I think they were probably changed like that because
these `BigInteger/double/float` issues were numerous and hard to pin down (thus
required quite a bit of time in the debugger).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
