paulirwin commented on code in PR #914:
URL: https://github.com/apache/lucenenet/pull/914#discussion_r1501721325
##########
src/Lucene.Net.Tests/Search/TestQueryRescorer.cs:
##########
@@ -363,7 +357,7 @@ public virtual void TestRandom()
//System.out.println("numHits=" + numHits + " reverse=" + reverse);
TopDocs hits = s.Search(new TermQuery(new Term("field", "a")),
numHits);
- TopDocs hits2 = new QueryRescorerAnonymousClass3(this, new
FixedScoreQuery(idToNum, reverse))
+ TopDocs hits2 = new QueryRescorerAnonymousClass3(new
FixedScoreQuery(idToNum, reverse))
Review Comment:
The code above these lines ensures that the doc IDs are positive so we don't
have to worry about the culture, but it is a best practice, so I've added the
culture anyways. I do not see any `int` passthrough Convert calls in this
class, but did fix that in the CheckHits class as mentioned earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
