NightOwl888 commented on code in PR #914:
URL: https://github.com/apache/lucenenet/pull/914#discussion_r1501760901
##########
src/Lucene.Net.Tests/Search/Spans/TestSpans.cs:
##########
@@ -556,6 +609,7 @@ public virtual void TestSpanNots()
[Test]
[Description("LUCENENET-597")]
+ [LuceneNetSpecific]
Review Comment:
> My guess is that the current behavior is fine as it just matches the .NET
type name and Boolean string formatting style in .NET.
Not consistently. Any code that uses the
[`J2N.Text.StringFormatter`](https://github.com/NightOwl888/J2N/blob/v2.0.0/src/J2N/Text/StringFormatter.cs#L35)
class to do the formatting will convert boolean values to lowercase. Any code
that does not will format them in uppercase.
That said, I agree this is outside of the scope of this PR, but perhaps it
would be good to add a new issue to review the formatting of boolean strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
