NightOwl888 commented on code in PR #914:
URL: https://github.com/apache/lucenenet/pull/914#discussion_r1501763220
##########
src/Lucene.Net.Tests/Search/TestBooleanQuery.cs:
##########
@@ -182,9 +182,6 @@ public virtual void TestDeMorgan()
IndexSearcher searcher = NewSearcher(multireader);
Assert.AreEqual(0, searcher.Search(query, 10).TotalHits);
-
- Task foo = new Task(TestDeMorgan);
-
TaskScheduler es = TaskScheduler.Default;
searcher = new IndexSearcher(multireader, es);
Review Comment:
I am referring to the `IndexSearcher` class, not this one. Removing the
debug code is a positive change. What I was wondering is whether it makes sense
to be able to cancel an in progress search (and whether it would function as
expected). We are using a .NET `TaskScheduler` here and `CancellationToken` is
part of the tool set. This isn't something that exists in Lucene 4.8.0, but I
think it would be useful to have in .NET if it can be implemented reliably.
That is, if there isn't some other way to cancel a search that I am unaware of.
Of course, this doesn't apply to this test, it would need to be tested
elsewhere, if implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
