NightOwl888 commented on code in PR #914:
URL: https://github.com/apache/lucenenet/pull/914#discussion_r1501764955
##########
src/Lucene.Net.Tests/Search/TestMultiThreadTermVectors.cs:
##########
@@ -60,7 +58,7 @@ public override void SetUp()
customType.StoreTermVectors = true;
for (int i = 0; i < numDocs; i++)
{
- Documents.Document doc = new Documents.Document();
+ Document doc = new Document();
Field fld = NewField("field", English.Int32ToEnglish(i),
customType);
Review Comment:
Yeah, I guess it is not that big of an issue. In Java, this was intentional
because the test framework simply needed English support and it wasn't worth
adding a dependency on ICU4J just for that. On the other hand, Benchmark
already had a dependency on ICU4J, which is why they used it there (even though
it only used English, also).
Although ICU4N now has support so we could technically remove
`EnglishNumberFormatExtensions` from `Lucene.Net.Benchmark`, the extension
methods will still probably outperform ICU4N so it is probably not worth it to
change it.
I just had it in the back of my mind that this was duplicated *somewhere*,
but couldn't remember where, exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
