paulirwin commented on code in PR #914:
URL: https://github.com/apache/lucenenet/pull/914#discussion_r1518643770
##########
src/Lucene.Net.Tests/Search/Spans/TestSpansAdvanced.cs:
##########
@@ -79,16 +82,9 @@ public override void SetUp()
[TearDown]
public override void TearDown()
{
- if (reader != null)
- {
- reader.Dispose();
- }
-
- if (mDirectory != null)
- {
- mDirectory.Dispose();
- mDirectory = null;
- }
+ reader.Dispose();
Review Comment:
With respect to the scope of this PR, I agree. I think we can avoid this
change in this PR for now as it's a miniscule example with very little benefit
to the maintainability of the unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
