paulirwin commented on code in PR #914:
URL: https://github.com/apache/lucenenet/pull/914#discussion_r1502745111


##########
src/Lucene.Net.Tests/Search/Spans/TestSpansAdvanced.cs:
##########
@@ -79,16 +82,9 @@ public override void SetUp()
         [TearDown]
         public override void TearDown()
         {
-            if (reader != null)
-            {
-                reader.Dispose();
-            }
-
-            if (mDirectory != null)
-            {
-                mDirectory.Dispose();
-                mDirectory = null;
-            }
+            reader.Dispose();

Review Comment:
   Ah lol forgot about the NRT in Lucene, sorry for the confusion. I could 
enable`#nullable` for this test class since we're talking about it, or just 
skip for now. Let me know if you'd like to see me add this. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to