paulirwin commented on code in PR #914:
URL: https://github.com/apache/lucenenet/pull/914#discussion_r1501849549
##########
src/Lucene.Net.Tests/Search/Spans/TestSpansAdvanced.cs:
##########
@@ -79,16 +82,9 @@ public override void SetUp()
[TearDown]
public override void TearDown()
{
- if (reader != null)
- {
- reader.Dispose();
- }
-
- if (mDirectory != null)
- {
- mDirectory.Dispose();
- mDirectory = null;
- }
+ reader.Dispose();
Review Comment:
Yep, by NRT I mean C#'s Nullable Reference Type checking with
`<Nullable>enable</Nullable>`. I couldn't make the `IndexReader` here be
`IndexReader?` without enabling it for the whole project. Currently only
Lucene.Net.Spatial appears to have NRT checking enabled. Also to clarify, by
4.8 I mean Lucene.net 4.8, not .NET Framework 4.8, in case that wasn't clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
