paulirwin commented on code in PR #914:
URL: https://github.com/apache/lucenenet/pull/914#discussion_r1501848700
##########
src/Lucene.Net.Tests/Support/TestCase.cs:
##########
@@ -1,50 +0,0 @@
-namespace Lucene.Net
-{
- /*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
- /// <summary>
- /// Support for junit.framework.TestCase.getName().
- /// {{Lucene.Net-2.9.1}} Move to another location after LUCENENET-266
- /// </summary>
- public static class TestCase // LUCENENET specific: CA1052 Static holder
types should be Static or NotInheritable
- {
- public static string GetName()
- {
- return GetTestCaseName(false);
- }
-
- public static string GetFullName()
- {
- return GetTestCaseName(true);
- }
-
- static string GetTestCaseName(bool fullName)
- {
- System.Diagnostics.StackTrace stackTrace = new
System.Diagnostics.StackTrace();
- for (int i = 0; i < stackTrace.FrameCount; i++)
- {
- System.Reflection.MethodBase method =
stackTrace.GetFrame(i).GetMethod();
- object[] testAttrs =
method.GetCustomAttributes(typeof(NUnit.Framework.TestAttribute), false);
- if (testAttrs != null && testAttrs.Length > 0)
- if (fullName) return method.DeclaringType.FullName + "." +
method.Name;
Review Comment:
Gotcha, filed #923 with links to both discussions for context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
