kaknikhil commented on a change in pull request #360: Deep Learning: Add
support for one-hot encoded dep var
URL: https://github.com/apache/madlib/pull/360#discussion_r270536919
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -267,6 +186,8 @@ def fit(schema_madlib, source_table, model,
dependent_varname,
if validation_aggregate_loss and len(validation_aggregate_loss) > 0:
final_validation_loss = validation_aggregate_loss[-1]
version = madlib_version(schema_madlib)
+ class_values, class_values_type = get_class_values_and_type(
+ fit_validator.class_values_colname, fit_validator.source_summary_table)
Review comment:
We don't really need to pass in the class_values_colname. The function
`get_class_values_and_type` can directly use the global var
`CLASS_VALUES_COLNAME`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
