kaknikhil commented on a change in pull request #360: Deep Learning: Add 
support for one-hot encoded dep var
URL: https://github.com/apache/madlib/pull/360#discussion_r270541866
 
 

 ##########
 File path: src/ports/postgres/modules/utilities/minibatch_validation.py_in
 ##########
 @@ -18,8 +18,20 @@
 # under the License.
 
 import plpy
+from utilities import _assert
+from utilities import is_valid_psql_type
+from utilities import NUMERIC, ONLY_ARRAY
+from validate_args import get_expr_type
+
+def is_var_one_hot_encoded_for_minibatch(table_name, var_name, expr_type=None):
+    # The dependent variable is always a double precision array in
 
 Review comment:
   Maybe we should change the name of the function to 
`validate_dependent_var_for_minibatch`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to