kaknikhil commented on a change in pull request #360: Deep Learning: Add support for one-hot encoded dep var URL: https://github.com/apache/madlib/pull/360#discussion_r270539449
########## File path: src/ports/postgres/modules/deep_learning/madlib_keras_predict.py_in ########## @@ -28,11 +28,16 @@ from keras.optimizers import * import numpy as np from utilities.model_arch_info import get_input_shape +from utilities.utilities import add_postfix from utilities.validate_args import input_tbl_valid from utilities.validate_args import output_tbl_valid -from madlib_keras_helper import convert_string_of_args_to_dict +from madlib_keras_wrapper import convert_string_of_args_to_dict +from madlib_keras_helper import get_class_values_and_type +from madlib_keras_helper import KerasWeightsSerializer +# TODO: Refactor this out to a predict specific class in madlib_keras_helper. +CLASS_VALUES_COLNAME = "class_values" Review comment: If we refactor the `get_class_values_and_type` function to remove the `class_values_colname` arg, then we don't really need this variable. Actually even if we don't change `get_class_values_and_type`, we still don't need this variable. We can just reuse the one from `madlib_keras_helper.py_in`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
