kaknikhil commented on a change in pull request #360: Deep Learning: Add support for one-hot encoded dep var URL: https://github.com/apache/madlib/pull/360#discussion_r270535848
########## File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in ########## @@ -31,103 +31,21 @@ from keras.models import * from keras.optimizers import * from keras.regularizers import * -from madlib_keras_helper import KerasWeightsSerializer +from madlib_keras_helper import FitInputValidator Review comment: I would suggest moving FitInputValidator to it's own python file. In a future PR, when we remove the reshaping code, we won't need the `get_data_as_np_array` function. We will then rename `madlib_keras_helper.py_in` to `madlib_keras_serializer.py_in`. Also do we need FitInputValidator to be a class ? The only `class-like`behavior we use right now is the `source_summary_table` property. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
