kaknikhil commented on a change in pull request #360: Deep Learning: Add
support for one-hot encoded dep var
URL: https://github.com/apache/madlib/pull/360#discussion_r270605652
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -296,16 +217,18 @@ def fit(schema_madlib, source_table, model,
dependent_varname,
$24 AS accuracy_validation,
$25 AS loss_validation,
$26 AS accuracy_iter_validation,
- $27 AS loss_iter_validation
+ $27 AS loss_iter_validation,
+ $28 AS class_values
Review comment:
can we use the `CLASS_VALUES_COLNAME` variable here instead of hardcoding it
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
