[
https://issues.apache.org/jira/browse/CONNECTORS-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958565#comment-13958565
]
Karl Wright commented on CONNECTORS-911:
----------------------------------------
Hi Ahmet,
The SolrConnector patch you propose uses the following:
{code}
- PoolingClientConnectionManager localConnectionManager = new
PoolingClientConnectionManager();
- localConnectionManager.setMaxTotal(1);
+ connectionManager = new PoolingHttpClientConnectionManager();
+ connectionManager.setMaxTotal(1);
{code}
In other places, I have not set a max total on the pool but instead on the
HttpClient object. I wonder which is more correct? If this way is more
correct then many other places should be changed too.
The idea of this code is to simply allow one HttpClient instance to be
allocated and used per Solr connection instance. The pool is there to allow
for reuse, but it is limited to one because we don't need more than one per
instance. It may be more technically correct to say we need one per route in
fact.
If you can do enough research to know what the *right* way to do this is, I'd
appreciate it a lot!
> Work on removing HttpClient 4.3 deprecation warnings
> ----------------------------------------------------
>
> Key: CONNECTORS-911
> URL: https://issues.apache.org/jira/browse/CONNECTORS-911
> Project: ManifoldCF
> Issue Type: Task
> Components: Elastic Search connector, Framework crawler agent, JIRA
> connector, Lucene/SOLR connector, OpenSearchServer connector, RSS connector,
> Web connector, Wiki connector
> Affects Versions: ManifoldCF 1.6
> Reporter: Karl Wright
> Assignee: Karl Wright
> Fix For: ManifoldCF 1.7
>
> Attachments: CONNECTORS-911.patch, SolrConnector.patch
>
>
> HttpClient 4.3 deprecates pretty much the entire way you used to build
> httpclient instances; fixing this requires a lot of work in ManifoldCF.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
